flit_core: refactor path handling to use pathlib #516
Conversation
jameshilliard
force-pushed
the
pathlib
branch
11 times, most recently
from
c932b0b to
aa616bf
Compare
| @@ -201,18 +231,18 @@ def _check_glob_patterns(pats, clude): | |||
| .format(clude, p) | |||
| ) | |||
|
|
|||
| normp = osp.normpath(p) | |||
| normp = posix_normpath(PurePosixPath(p)) | |||
There was a problem hiding this comment.
This looks like a behaviour change on Windows -- since it's switching from Windows paths to POSIX paths.
There was a problem hiding this comment.
The path handling seemed buggy/inconsistent here since os.path.normpath is filesystem/os specific and these validations I think need to be consistent across platforms.
There was a problem hiding this comment.
The tests already expect these paths to always be posix style at the moment, as this path is not an absolute path on windows:
flit/flit_core/flit_core/tests/test_config.py
Line 109 in 6982fae
|
I'm not sure that it is particularly useful to make such a migration, but I'll leave the merits of thinking about those to others. |
jameshilliard
force-pushed
the
pathlib
branch
2 times, most recently
from
77ce6ab to
6b44347
Compare
jameshilliard
force-pushed
the
pathlib
branch
from
6b44347 to
c0372ae
Compare
This should make path handling easier/cleaner compared with using
os.path.