Switch TOML library to tomli #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The coverage drop is because there's some code specific to Python < 3.6, which is now unused. I'll remove that in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tomli has rapidly become the de-facto standard. It's also compatible with some changes made for TOML version 1.0, which people are going to want to use.
This means the end of the line for Python 3.4 and 3.5 support in flit_core. Projects which still support those versions will need to ensure they can be built by flit_core version 3.3.0 (which means sticking to TOML 0.5). Both of those Python versions are already end-of-life in that they're not getting bugfix releases, so hopefully not many people are affected by this.