Code

Allow path objects for data-files#272

Code

Merged

jaraco merged 18 commits intomainpypa/distutils:mainfrom feature/pathlib-data-filespypa/distutils:feature/pathlib-data-filesCopy head branch name to clipboardJul 20, 2024

+84-90

Commits

Commits on Jul 19, 2024

• Allow path objects

  

  InvincibleRMC

  authored and

  jaraco

  committed
  d3c76bb

  Copy full SHA for d3c76bb

• Need to include 'three' in the input.

  jaraco

  committed
  12f2ef0

  Copy full SHA for 12f2ef0

• Consolidate str and Path handling.

  jaraco

  committed
  8a9ca8b

  Copy full SHA for 8a9ca8b

• Expand convert_path to also accept pathlib.Path objects.

  jaraco

  committed
  206ca2a

  Copy full SHA for 206ca2a

• Prefer simply 'pathlib' for import.

  jaraco

  committed
  f7adff4

  Copy full SHA for f7adff4

• Extract a singledispatchmethod _copy for handling the copy of each data file.

  jaraco

  committed
  b440f45

  Copy full SHA for b440f45

• Use explicit registration for compatibility with older Pythons.

  Show description for 94b6d14
  jaraco

  committed
  94b6d14

  Copy full SHA for 94b6d14

• Prefer os.PathLike in convert_path

  jaraco

  committed
  4d50db3

  Copy full SHA for 4d50db3

• Convert needs to accept None for Setuptools' sake.

  jaraco

  committed
  e88bd79

  Copy full SHA for e88bd79

• In test_convert_path, utilize posixpath.join and ntpath.join for maximum compatibility with other libraries.

  jaraco

  committed
  d48a881

  Copy full SHA for d48a881

• Wrap paths in PurePosixPath to ensure that any WindowsPaths don't get backslashes.

  jaraco

  committed
  8eb6b57

  Copy full SHA for 8eb6b57

• convert_path no longer fails if passed a path with a trailing slash. Instead, trailing slashes are stripped just as they are with pathlib.Path.

  Show description for 4232b01
  jaraco

  committed
  4232b01

  Copy full SHA for 4232b01

Commits on Jul 20, 2024

• convert_path now converts to a platform-native path.Path, but then calls .as_posix() on it.

  Show description for b4df774
  jaraco

  committed
  b4df774

  Copy full SHA for b4df774

• Separate test_convert_path into two tests to avoid interactions in monkeypatching os.path.

  jaraco

  committed
  c67da35

  Copy full SHA for c67da35

• Remove expectation that a ValueError is raised for data_files being drive-relative absolute on Windows.

  jaraco

  committed
  1e97e21

  Copy full SHA for 1e97e21

• Simplify convert_path by simply relying on the logic in PurePath.

  Show description for 4b3f16f
  jaraco

  committed
  4b3f16f

  Copy full SHA for 4b3f16f

• Harmonize convert_path tests across Unix and Windows.

  jaraco

  committed
  c4d3c3c

  Copy full SHA for c4d3c3c

• Consolidate convert_path tests and just generate the expected value in a platform-sensitive way. Should fix failures on mingw.

  jaraco

  committed
  a166815

  Copy full SHA for a166815