Allow path objects for data-files #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaraco
commented
Jul 19, 2024
distutils/command/install_data.py
Outdated
| @@ -56,6 +57,16 @@ def run(self): | |||
| ) | |||
| (out, _) = self.copy_file(f, self.install_dir) | |||
| self.outfiles.append(out) | |||
| elif isinstance(f, Path): | |||
There was a problem hiding this comment.
This covers the case that one of the data files is a simple pathlib.Path, but it doesn't cover the case if a pathlib.Path is used in a tuple (in the else block below).
There was a problem hiding this comment.
Ah you are right. Should I fix it or do you want to fix it?
There was a problem hiding this comment.
I'm on it. But thanks for offering.
There was a problem hiding this comment.
My thinking is that convert_path already wraps all the places where a Path might be encountered, so probably that should be expanded to account for pathlib.Path.
Prior to 3.11, singledispatch[method] doesn't know about unions.
|
Looks like I jumped the gun on the merge. I've backed out the merge and going to re-submit (#272). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from pypa/setuptools#4495 by @InvincibleRMC.