Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate mkdocs_include_markdown_plugin from documentation #475

Merged

Conversation

mondeja
Copy link
Contributor

@mondeja mondeja commented Dec 4, 2020

As was discussed in #470, the plugin mkdocs_include_markdown_plugin have been separated into new package mkdocs-include-markdown-plugin.

Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers @mondeja !

@YannickJadoul
Copy link
Member

Great, let's merge this! :-)

@mondeja, one more small thing: how much time will you have to maintain the package? I'm just thinking we will now depend on this project that used to be vendored. Of course we can make a PR if necessary, but just curious/hoping to hear that that would then get merged soon enough? :-)

It's just that I'm seeing talks in #474 about including different parts from the README, and I realized we won't have full control anymore over this plugin in the rare case something needs to be changed. But all of that is fine if you'll have enough time. If at some point you don't, do please let us know! It would be sad to see the project go.

(Also, depends a bit on what @joerick would want, but since it's his brainchild, I guess you could add him as "passive maintainer"?)

@mondeja
Copy link
Contributor Author

mondeja commented Dec 6, 2020

how much time will you have to maintain the package?

Don't worry, every day I help with the maintenance of several open source projects that I need both in my work and in my individual projects, and I don't like unmaintained projects at all, so I am aware of what it means, being usually operational for revisions 95% of the days of the year. I'm sure that if you open a pull request, since the plugin now contains tests, they will be easy to review.

I guess you could add him as "passive maintainer"?

Just let me know if one of more of you want to be added as maintainers with full permissions, both for the project in PyPI and the Github repository.

@YannickJadoul
Copy link
Member

OK, thanks for quickly setting my mind at ease! :-)

Given that @joerick already approved, let's get this merged. Thanks a lot for the initiative, @mondeja!

@YannickJadoul YannickJadoul merged commit eae3483 into pypa:master Dec 6, 2020
@mondeja mondeja deleted the separate-mkdocs-include-markdown-plugin branch May 31, 2021 17:20
@mondeja mondeja changed the title Separate 'mkdocs_include_markdown_plugin' from documentation Separate mkdocs_include_markdown_plugin from documentation Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants