-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing macOS CI and tests after lastest release of virtualenv #270
Conversation
@Czaki See here as well. |
This is next things that show why PR #256 is really important... |
Ah, yes, I still need to give that a look! |
Problem is when next release of package breaks the cibuildwheel like virtualenv. You have no information about this until someone try to introduce next change. If dependabot will be introduced it will create PR with upgraded version of package and then build will failed and you will have information that it is a problem. |
I think you're right, @Czaki, that the installed scripts keep a reference to the old virtualenv from the first part of the test. Now the question is why, and if we can reproduce it with a simple script? |
I understand. I am just afraid we will need to make a lot of releases of |
For me it is connected with bug mentioned in virtualenv documentation. sciript draft :
Why? #256 offers to run in most modern mode, allow to define own package version and you will have no problem that your build system stops working because someone upgrade his own package. I do no see any profit of create release for every version bump. |
@joerick How it looks from your side? |
@Czaki Thanks for the demo-script. I've added a comment to the existing issue: pypa/virtualenv#1561 (comment) |
2ff9121
to
691174c
Compare
If this works, I'll merge it. It's getting too annoying that the master is broken. |
I guess this needs a release ASAP? |
This error occuress only when someone call cibuildwheel twice on same macos machine. So it is no such critical. Maybe may wait on #185. |
ah, okay. That explains why we haven't seen any bug reports from users for this :) |
Isolating build issues from #185, seemingly related to virtualenv 20.
(Sorry for the PR pollution, but this might be the easiest way to test out a few things.)