-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added libresolv to the whitelisted libraries #81
Conversation
Hmmmm, at first glance I don't think this is bitrotted. If we add a new file to the policy we'll need to also ensure all its symbols are represented in the policy list. Perhaps that's why this failed? |
The library's part of glibc so it shouldn't need any new symbols. From a quick glance it looked like the tests were failing because they were trying to fetch some remote url and getting a 404. |
looks at Travis build Aha, I dunno what https://github.com/getnikola/wheelhouse/archive/v2.7.zip is but it's 404ing. That definitely isn't a test I wrote. Will let y'all take a look first. |
Is anyone working on fixing these build problems? They seem unrelated to this pull request. This issue affects other libraries that we are building our own wheels for; for example mysqlclient. |
I don't think anyone is working on fixing the build problems. It's my code / my fault. The 404 is surely because I found some wheels on github to use as tests. If anyone has the bandwidth to clean up the tests a little bit -- even just remove the failing test -- that would be great. |
I'll see if I can just remove it for now. |
(cc #86) |
Hi @dvarrazzo, you can now rebase this PR and the build should pass! |
71c016a
to
ad77b3f
Compare
Ready to merge |
Fix #80