Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use thread pool #554

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

feat: use thread pool #554

wants to merge 22 commits into from

Conversation

oraluben
Copy link
Contributor

@oraluben oraluben commented Mar 7, 2025

Use multithread to run IO-bounded jobs (e.g. shell command) concurrently.

Part of #545

TODO:

  • pass test with j=1
  • fuzz with different j
  • cli argument
  • doc
  • test
  • test time

@oraluben oraluben force-pushed the pool branch 2 times, most recently from 7d8abfd to b3599aa Compare March 7, 2025 13:54
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 76.99115% with 26 lines in your changes missing coverage. Please review.

Project coverage is 90.97%. Comparing base (3e4b6b3) to head (1da1db7).

Files with missing lines Patch % Lines
src/auditwheel/pool.py 47.72% 20 Missing and 3 partials ⚠️
src/auditwheel/repair.py 92.30% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   92.17%   90.97%   -1.20%     
==========================================
  Files          22       23       +1     
  Lines        1572     1640      +68     
  Branches      286      294       +8     
==========================================
+ Hits         1449     1492      +43     
- Misses         74       95      +21     
- Partials       49       53       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oraluben oraluben marked this pull request as ready for review March 11, 2025 03:50
@oraluben

This comment has been minimized.

@mayeut
Copy link
Member

mayeut commented Mar 16, 2025

@oraluben, do you have any timings for this one ? I'd rather not increase the complexity of auditwheel if the improvement is small given maintainer bandwidth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants