Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append to RPATH (instead of overwrite) #140

Closed
wants to merge 1 commit into from

Conversation

thomaslima
Copy link
Contributor

@thomaslima thomaslima commented Feb 1, 2019

Closes #137

Test cases in #134

Not-implemented caveat: #134 (comment)

@ferdonline
Copy link

ferdonline commented Mar 24, 2020

Hi @thomaslima
Any update on this PR? In our project we also depend on internal libraries and require the previous RPATH to be respected.
Independently I arrived to a very similar solution.

prev_rpath = check_output(['patchelf', '--print-rpath', fn]).decode().rstrip('\n\t /')
check_call(['patchelf', '--remove-rpath', fn])
if prev_rpath and prev_rpath != rpath:
    rpath += ":" + prev_rpath

Feel free to use it.
In this PR, however, it seems the tests fail for some unrelated reason.
We would be happy to help this getting fixed. Thanks!

@thomaslima
Copy link
Contributor Author

@ferdonline I'd really like some help. I have absolutely no time to look into this at the moment =(

@fbrennen
Copy link
Contributor

fbrennen commented Jun 5, 2020

Hi @thomaslima -- I had a quick go at updating your PR here: #245

@lkollar
Copy link
Contributor

lkollar commented Jun 22, 2020

#245 implemented this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPATH is being incorrectly overwritten
5 participants