Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the distance between markers and experimental markers #90

Merged
merged 4 commits into from
Feb 28, 2023

Conversation

pariterre
Copy link
Member

@pariterre pariterre commented Feb 10, 2023

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b24a5e7) 0.00% compared to head (67ca649) 0.00%.

❗ Current head 67ca649 differs from pull request most recent head c596f37. Consider uploading reports for the commit c596f37 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master     #90   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          10      10           
  Lines        2625    2698   +73     
======================================
- Misses       2625    2698   +73     
Impacted Files Coverage Δ
bioviz/__init__.py 0.00% <0.00%> (ø)
bioviz/biorbd_vtk.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pariterre
Copy link
Member Author

This PR also fixed the crazy slow bug (#87)

@pariterre pariterre merged commit ec1f299 into pyomeca:master Feb 28, 2023
@Ipuch
Copy link
Contributor

Ipuch commented Feb 28, 2023

Shouldn't we have a test to verify that object or not created multiple times ? :)

@pariterre
Copy link
Member Author

That is impossible to test properly, not without a long and painful process at least...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants