Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show experimental markers from c3d or markers arrays. #55

Merged
merged 5 commits into from
Sep 9, 2021

Conversation

aceglia
Copy link
Contributor

@aceglia aceglia commented Sep 7, 2021

TODO: find a better place to raise error message if number of markers' frame not match number of Q frames

@pariterre
Copy link
Member

Hi @aceglia
I made some changes. Now if you want to load the markers data, it should not be passed in the constructor, but using the method load_experimental_data or load_c3d.

I allowed to load a c3d file without loading any model as well, which can be useful to see a C3D (only markers so far)

Thanks for the PR!

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pariterre pariterre changed the title [WIP] Show experimental markers from c3d or markers arrays. Show experimental markers from c3d or markers arrays. Sep 9, 2021
@pariterre pariterre merged commit 18f5ebb into pyomeca:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants