Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JsException unpickle special case #91

Merged
merged 11 commits into from
Jun 1, 2023

Conversation

hoodmane
Copy link
Member

@hoodmane hoodmane commented May 31, 2023

This code is no longer needed and causes trouble.

Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

[pyodide/pyodide#3387](https://github.com/pyodide/pyodide/pull/3387).
[#91](https://github.com/pyodide/pytest-pyodide/pull/91)

- Dropped support for Pyodide version `0.21.x`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me.

@ryanking13 ryanking13 merged commit 85d56c9 into pyodide:main Jun 1, 2023
@hoodmane hoodmane deleted the remove-jsexception-unpickle branch June 1, 2023 16:10
@hoodmane
Copy link
Member Author

hoodmane commented Jun 1, 2023

Thanks for the review @ryanking13!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants