-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed default html templates #87
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2f86d75
Include test templates to pytest-pyodide
ryanking13 901ddde
Forward paths
ryanking13 16ccf41
Add pytest-cov to test dependency
ryanking13 028551c
Fix handler
ryanking13 b515066
Fix syntax in optional dependencies
ryanking13 0ca0361
Remove temp html file
ryanking13 b292fca
Expose DefaultHandler
ryanking13 0c13714
Add test
ryanking13 29acdff
Replace module_test.html with the correct one
ryanking13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
<!-- Bootstrap HTML for running the unit tests. --> | ||
<!doctype html> | ||
<html> | ||
<head> | ||
<script type="text/javascript"> | ||
window.logs = []; | ||
console.log = function (message) { | ||
window.logs.push(message); | ||
}; | ||
console.warn = function (message) { | ||
window.logs.push(message); | ||
}; | ||
console.info = function (message) { | ||
window.logs.push(message); | ||
}; | ||
console.error = function (message) { | ||
window.logs.push(message); | ||
}; | ||
</script> | ||
<script type="module"> | ||
import { loadPyodide } from "./pyodide.mjs"; | ||
window.loadPyodide = loadPyodide; | ||
</script> | ||
</head> | ||
<body></body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
<!-- Bootstrap HTML for running the unit tests. --> | ||
<!doctype html> | ||
<html> | ||
<head> | ||
<title>pyodide</title> | ||
<script type="text/javascript"> | ||
window.logs = []; | ||
console.log = function (message) { | ||
window.logs.push(message); | ||
}; | ||
console.warn = function (message) { | ||
window.logs.push(message); | ||
}; | ||
console.info = function (message) { | ||
window.logs.push(message); | ||
}; | ||
console.error = function (message) { | ||
window.logs.push(message); | ||
}; | ||
console.debug = function (message) { | ||
window.logs.push(message); | ||
}; | ||
</script> | ||
<script src="./pyodide.js"></script> | ||
</head> | ||
<body></body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have this? This
_templates
directory is not a submodule, it has data files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned here, I wasn't able to make
packages: find
to locate data files in subdirectories correctly. So I added__init__.py
as a hack to make setuptools add that directory to the wheel. I don't wanted to usepackages = find_namespace:
since it often adds unwanted directories to wheels when we are not careful.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can get @henryiii to help...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the correct way to make it accessible to
importlib.metadata
. If you don't need that, then you can make it available via setting package_data. Though what do you think about just moving to hatchling or flit-core, which IMO are much easier to configure?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am in favor of moving to a different build backend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Does hatchling or flit support auto versioning? We use setuptools-scm for versioning.
(TBH, I haven't used those build backends before)