Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change --runtime flag to accept comma-separated list of runtimes #76

Merged
merged 10 commits into from
Dec 15, 2022

Conversation

ryanking13
Copy link
Member

@ryanking13 ryanking13 commented Dec 14, 2022

Previously --runtime (--rt) flag accepted list of arguments:

pytest --rt chrome firefox node

but this often caused problem as it swallows all following arguments (#75 (comment)).

This PR changes it to accept comma-separated list or arguments instead:

pytest --rt "chrome, firefox, node"

This might be a breaking change for someone.

cc: @joemarshall

  • changelog

pytest_pyodide/hook.py Show resolved Hide resolved
pytest_pyodide/hook.py Show resolved Hide resolved
@ryanking13 ryanking13 merged commit 6c7d644 into pyodide:main Dec 15, 2022
@ryanking13 ryanking13 deleted the runtime-args branch December 15, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants