Add Safari runner for selenium #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, I think we can tag and release this. I'm going to bump the version to 0.22 as I think it's weird to add features in a patch release, and we are not going to be able to keep this version in sync with pyodide distro release. So we might as well deviate already now. |
Yes, sounds good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds safari runner for selenium, mostly adopted from @rth's PR in Pyodide pyodide/pyodide#2578
I also added
selenium_standalone_refreshfixture which I experimented in pyodide/pyodide#2957.Since selenium allows only one Safari browser instance active at any given time, the original
selenium_standaloneis not very suitable for Safari test.I am not sure whether we should fully replace
selenium_standalonewithselenium_standalone_refresh, as it is not tested very much yet. So I made a separate fixture and add an option (STANDALONE_REFRESHenv variable) which dynamically overridesselenium_standalonewithselenium_standalone_refresh. I am open to better ideas.