-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a global manager for configuring runtimes #141
Merged
Merged
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
332a94f
Add global config manager
ryanking13 a65a559
Add test
ryanking13 ed28c40
lint
ryanking13 8870f02
Fix order
ryanking13 2bd5543
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7b6bfff
lint
ryanking13 fab3beb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] cb38d83
lint
ryanking13 67ca779
Merge branch 'global-state-manager2' of https://github.com/ryanking13…
ryanking13 9f888a8
lint
ryanking13 0928235
Use ploral
ryanking13 8c8a163
changelog
ryanking13 5eceaa9
58.3
ryanking13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
""" | ||
Stores the global runtime configuration related to the pytest_pyodide package. | ||
""" | ||
|
||
from typing import Literal | ||
|
||
RUNTIMES = Literal["chrome", "firefox", "node", "safari"] | ||
|
||
_global_load_pyodide_script = """ | ||
let pyodide = await loadPyodide({ fullStdLib: false, jsglobals : self }); | ||
""" | ||
|
||
|
||
class Config: | ||
def __init__(self): | ||
# Flags to be passed to the browser or runtime. | ||
self.flags: dict[RUNTIMES, list[str]] = { | ||
"chrome": ["--js-flags=--expose-gc"], | ||
"firefox": [], | ||
"node": [], | ||
"safari": [], | ||
} | ||
|
||
# The script to be executed to load the Pyodide. | ||
self.load_pyodide_script: dict[RUNTIMES, str] = { | ||
"chrome": _global_load_pyodide_script, | ||
"firefox": _global_load_pyodide_script, | ||
"node": _global_load_pyodide_script, | ||
"safari": _global_load_pyodide_script, | ||
} | ||
|
||
# The script to be executed to initialize the runtime. | ||
self.initialize_script: str = "pyodide.runPython('');" | ||
|
||
def set_flag(self, runtime: RUNTIMES, flags: list[str]): | ||
self.flags[runtime] = flags | ||
|
||
def get_flag(self, runtime: RUNTIMES) -> list[str]: | ||
return self.flags[runtime] | ||
|
||
def set_load_pyodide_script(self, runtime: RUNTIMES, load_pyodide_script: str): | ||
self.load_pyodide_script[runtime] = load_pyodide_script | ||
|
||
def get_load_pyodide_script(self, runtime: RUNTIMES) -> str: | ||
return self.load_pyodide_script[runtime] | ||
|
||
def set_initialize_script(self, initialize_script: str): | ||
self.initialize_script = initialize_script | ||
|
||
def get_initialize_script(self) -> str: | ||
return self.initialize_script | ||
|
||
|
||
SINGLETON = Config() | ||
|
||
|
||
def get_global_config() -> Config: | ||
""" | ||
Return the singleton config object. | ||
""" | ||
return SINGLETON |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
from pytest_pyodide.config import Config, get_global_config | ||
|
||
|
||
def test_config(): | ||
c = Config() | ||
|
||
runtimes = ["chrome", "firefox", "node", "safari"] | ||
|
||
for runtime in runtimes: | ||
c.get_flag(runtime) | ||
c.get_load_pyodide_script(runtime) | ||
|
||
c.set_flag(runtime, ["--headless"]) | ||
assert c.get_flag(runtime) == ["--headless"] | ||
|
||
c.set_load_pyodide_script(runtime, "console.log('hello')") | ||
assert c.get_load_pyodide_script(runtime) == "console.log('hello')" | ||
|
||
c.get_initialize_script() | ||
c.set_initialize_script("console.log('hello')") | ||
assert c.get_initialize_script() == "console.log('hello')" | ||
|
||
|
||
def test_global_config(): | ||
assert get_global_config() is get_global_config() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this be
get_flags
/set_flags
plural?