Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop node < v18 support #113

Merged
merged 6 commits into from
Oct 28, 2023
Merged

Drop node < v18 support #113

merged 6 commits into from
Oct 28, 2023

Conversation

ryanking13
Copy link
Member

@ryanking13 ryanking13 commented Oct 25, 2023 •
edited
Loading

Drops node < v18 support from pytest-pyodide. Also update tested Pyodide versions.

  • changelog

hoodmane
hoodmane approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@hoodmane hoodmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hoodmane
Copy link
Member

I guess node 16 had an early end of life:
https://nodejs.org/en/blog/announcements/nodejs16-eol

Maybe we should drop support in Pyodide too...

@ryanking13
Copy link
Member Author

Maybe we should drop support in Pyodide too...

Yeah, I am working on it too.

@hoodmane
Copy link
Member

Thanks!

@ryanking13 ryanking13 merged commit 4d236f3 into pyodide:main Oct 28, 2023
33 of 35 checks passed
@ryanking13 ryanking13 deleted the drop-node-14-16 branch October 28, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoodmane hoodmane hoodmane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanking13 @hoodmane