Blog post on Rust/Cryptography #31
Conversation
✅ Deploy Preview for pyodide-blog ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
content/posts/rust.md
Outdated
| the Rust team for reviewing and merging patches to improve Emscripten support. | ||
| Thanks to the PyO3 team for their help and enthusiasm and for adding Emscripten | ||
| tests to their continuous integration. Special thanks to the Emscripten team, | ||
| particularly Sam Clegg, for their technical advice, for merging patches, and for |
There was a problem hiding this comment.
Nice! Great to see you name pop up in my feed Alex. I hope you are good!
|
The post content looks great, but the excerpt from the list of posts looks odd:
|
|
Thanks for the ping, this was a fascinating read. Glad to see you found a path and I hope we'll be able to drop 3.6 early next year to improve our deps a bit! |
There was a problem hiding this comment.
Thanks for this work and your contribution to the ecosystem!
The post reads nicely. It's pretty advanced though and readers not familiar with Emscripten or Rust (or which don't have some general knowledge of build toolchains) might be a bit lost. So I'm not sure what best to do about it,
- leave it as is and people will decide by themselves whether to read it.
- explain more of the concepts, but it's already a long post and it touches on a lot of things, so making it even longer would not be ideal.
- add a disclamer sentence toward the beginning to mention that this post requires minimal knowledge of [...] topics, and give some references to learn more about those. Though then maybe we would lose readers who would actually be interested in reading it, even if they don't have the pre-requisites.
A few comments/suggestions otherwise overall LGTM, though I don't know much about some of the topics discussed.
I agree we can probably publish it on Wednesday or Thursday.
content/posts/rust.md
Outdated
| ``` | ||
| Unable to find library `-lc-debug` | ||
| ``` | ||
| For some reason, Rust tries to link `libc` into Emscripten dynamic libraries. It |
There was a problem hiding this comment.
Well, it's the default behavior on Linux as far as I know, so it's not too surprising. What's probably more unexpected is Emscripten's workflow with libc linked into the main module.
There was a problem hiding this comment.
Agreed.
See also discussion:
emscripten-core/emscripten#17191 (comment)
rust-lang/rust#98303
Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
I would also be fine with removing some of the less interesting sections. But in case anyone else trying to build Rust code for |
| Thanks to the Cryptography team for making this necessary and for their | ||
| technical advice. Thanks to the <code class="pkg">chrono</code> maintainers and | ||
| the Rust team for reviewing and merging patches to improve Emscripten support. | ||
| Thanks to the PyO3 team for their help and enthusiasm and for adding Emscripten |
| symbol is the `PyInit__my_module` function that Python invokes when loading a | ||
| native module. | ||
|
|
||
| It would be great to link our other extension modules with `-sSIDE_MODULE=2` but |
There was a problem hiding this comment.
I'm a little unsure what this is aspiring to (what "our other extension modules" are).
| is not passed to the linker. Conveniently, Rust is good at calculating which | ||
| symbols should be exported: public symbols with the `#[no_mangle]` attribute are | ||
| exported, other symbols are not. In the case of a PyO3 module, the only exported | ||
| symbol is the `PyInit__my_module` function that Python invokes when loading a |
There was a problem hiding this comment.
So does Rust pass this symbol automatically to the linker, or did you have to add it to the command line?
There was a problem hiding this comment.
Rust automatically passes the information to the linker when building a cdylib, this is handled here:
https://github.com/rust-lang/rust/blob/master/compiler/rustc_codegen_ssa/src/back/link.rs#L1882
Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
|
@hoodmane Feel free to merge once you have responded to above comments. Just need to make sure that the date in the header is today and in the past (otherwise if it's in the future it won't be published). Also if you have a short description for posting this on Twitter, please send it to me, otherwise, I'll write something. Thanks! |
@reaperhulk @alex @davidhewitt @messense @sbc100