Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scene naming support for non anime shows #8155

Merged
merged 10 commits into from
May 31, 2020
Merged

Add scene naming support for non anime shows #8155

merged 10 commits into from
May 31, 2020

Conversation

medariox
Copy link
Contributor

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@medariox medariox added this to the 0.3.17 milestone May 29, 2020
@medariox medariox changed the title Feature/add naming non anime Add scene naming support for non anime shows May 29, 2020
@p0psicles
Copy link
Contributor

Maybe you should add some tests that prove the functionality? I can help with that if you'd like

medariox and others added 3 commits May 31, 2020 15:03
@medariox
Add tests, simplify get_scene_exception_by_name
0633220
@medariox
Add one more test
6f62ed1
@p0psicles
Fix pytest.
c534481 
* When using the function mocks. It will overwrite the function of the module, it's attached to.
Like this_module.i_want_to_mock_this().
You cant do:
from this_module import i_want_to_mock_this(). As then when called, it can't detect the parent module.
So you'll have to do:
import this_module.
this_module.i_want_to_mock_this().
p0psicles
p0psicles previously approved these changes May 31, 2020
View reviewed changes
@p0psicles
Copy link
Contributor

Hmm it seemed the test was successful when running it local?

p0psicles
p0psicles previously approved these changes May 31, 2020
View reviewed changes
@medariox medariox merged commit 4403063 into develop May 31, 2020
@medariox medariox deleted the feature/add-naming-non-anime branch May 31, 2020 16:30
@p0psicles p0psicles added this to the 0.4.0 milestone Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0psicles p0psicles p0psicles approved these changes

Assignees
No one assigned
Labels
Concluded Enhancement
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@medariox @p0psicles