Convert Quality Chooser to SFC #6737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkykh
added
Needs testing
Open
sharkykh
added
Frontend
and removed
Needs test (Vue)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
- Fix preset selector changing to a preset if the custom-selected qualities sum up to that preset. - Fix empty custom view when previous preset was `keep`. - Fix recalculating backlogged episodes after archiving. - Fix backlogged episodes text always showing in red. - Catch errors in async backlogged episodes computed prop. - Use reduce instead of `filter`+`map` (more efficient) - Remove unneeded map to integers on allowed/preferred watches (reason - `.number` modifer was missing on the `v-model`s)
sharkykh
force-pushed
the
vueify/sfc-quality-chooser
branch
from
f23714d to
a2bca5b
Compare
sharkykh
added
Needs review
Concluded
and removed
Do not merge
On hold
Needs testing
p0psicles
reviewed
Jun 2, 2019
p0psicles
approved these changes
Jun 2, 2019
Thilas
pushed a commit
to Thilas/Medusa
that referenced
this pull request
Jun 5, 2019
* Fixes for `quality-chooser` - Fix preset selector changing to a preset if the custom-selected qualities sum up to that preset. - Fix empty custom view when previous preset was `keep`. - Fix recalculating backlogged episodes after archiving. - Fix backlogged episodes text always showing in red. - Catch errors in async backlogged episodes computed prop. - Use reduce instead of `filter`+`map` (more efficient) - Remove unneeded map to integers on allowed/preferred watches (reason - `.number` modifer was missing on the `v-model`s) * Rename to SFC and register, comment out Python code * Move "initial quality" code to `main.mako` * Simple linting * Update backlog link * Replace with getters and import `api` * Add component to AddShowOptions * Add basic QualityChooser tests * Fix bugs - Clear the preferred selection when deselecting all allowed qualities - If changing to **OR from** `keep`, restore the original value * Get the default show quality from the store * Replace `seriesSlug` with `showSlug` prop * Fix show qualities key in API description * Simplify `manage_massEdit` * Sort out the template and inline styles * Update CHANGELOG.md * [Bundle]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's mostly done... but don't merge yet.quality-chooserkeep.filter+map(more efficient)(reason -
.numbermodifer was missing on thev-models)keep, restore the original valuemain.makoapiseriesSlugwithshowSlugpropmanage_massEdit