Refactor notify_snatch to use title, message instead of episode name #5584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DeepCode analyzed this pull request. |
p0psicles
reviewed
Nov 3, 2018
|
Yes, no problem. Will need some more time for this PR. |
|
DeepCode analyzed this pull request. |
medariox
changed the title
This was referenced Nov 5, 2018
Merged
p0psicles
approved these changes
Nov 5, 2018
|
|
||
| msg['Subject'] = 'New Login from IP: {0}'.format(ipaddress) | ||
| msg['Subject'] = '{0}: {1}'.format(title, ipaddress) |
There was a problem hiding this comment.
These new subjects are somewhat less informative then the old. Whas that on purpose?
There was a problem hiding this comment.
Ow i swe that these gave all been added to notifystrings. Never mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is based on the DEVELOP branch
Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
Read the contribution guide
Includes: Refactor of email notifications. Should fix: [APP SUBMITTED]: BraceException: Email notifier parsed "{0}" into {1!r} #5583