Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torrentday: Switched back to the new rest api. #3727

Merged
merged 4 commits into from
Feb 9, 2018

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Feb 8, 2018

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

With special tnx to: @kayl669

@p0psicles p0psicles requested a review from duramato February 8, 2018 10:02
params = dict({'q': search_string}, **self.categories[mode])

if self.freeleech:
params.update({'free': 'on'})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this still has any effect?

Copy link
Contributor

@fernandog fernandog Feb 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik its to only list free leech torrents. @duramato confirm?
Last time i accessed TD It was available the information

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but is it available through the new api?

@codecov-io
Copy link

codecov-io commented Feb 8, 2018

Codecov Report

Merging #3727 into develop will decrease coverage by 0.1%.
The diff coverage is 35.89%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3727      +/-   ##
===========================================
- Coverage    28.88%   28.78%   -0.11%     
===========================================
  Files          277      279       +2     
  Lines        35005    35627     +622     
===========================================
+ Hits         10112    10255     +143     
- Misses       24893    25372     +479
Impacted Files Coverage Δ
medusa/providers/torrent/__init__.py 100% <ø> (ø) ⬆️
medusa/providers/torrent/json/torrentday.py 35.89% <35.89%> (ø)
medusa/helpers/utils.py 50% <0%> (-8.83%) ⬇️
medusa/logger/adapters/style.py 68.49% <0%> (-2.7%) ⬇️
medusa/subtitles.py 53.87% <0%> (-2.08%) ⬇️
medusa/tv/episode.py 18.61% <0%> (-1%) ⬇️
medusa/show_queue.py 0% <0%> (ø) ⬆️
medusa/statistics/weights.py 66.66% <0%> (ø)
medusa/statistics/__init__.py 34.61% <0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30e65ec...bd91d66. Read the comment docs.

@p0psicles
Copy link
Contributor Author

reminder to myself. Remove the freeleech param. And filter using "download-multiplier":0

@fernandog
Copy link
Contributor

@p0psicles where is the API documentation? I couldn't find

@p0psicles
Copy link
Contributor Author

Don't think there is any

@fernandog
Copy link
Contributor

@@ -138,6 +135,10 @@ def parse(self, data, mode):
" minimum seeders: {0}. Seeders: {1}", title, seeders)
continue

# Check if this is a freeleech torrent and if we've configured to only allow freeleech.
if self.freeleech and row['download-multiplier'] != 0:
continue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@p0psicles why not discard freeleech earlier before setting title ? title = re.sub(... - line 120

@p0psicles p0psicles merged commit db79177 into develop Feb 9, 2018
@p0psicles p0psicles deleted the feature/torrentday-back-to-rest-api branch February 9, 2018 14:04
@p0psicles p0psicles added this to the 0.2.0 milestone Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants