-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only apply UTF-8 monkey patch when necessary #3573
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3573 +/- ##
===========================================
- Coverage 33.02% 33.02% -0.01%
===========================================
Files 274 274
Lines 34735 34748 +13
===========================================
+ Hits 11471 11475 +4
- Misses 23264 23273 +9
Continue to review full report at Codecov.
|
Thanks for the contribution! We still need to monkey patch to support unicode input for pyOpenSSL, so this solution won't cut it. Don't you think that there is a problem with the Python implementation in Entware-ng? |
The problem was resolved by skipping the I'd argue that monkey patching python core modules is a bit more dirty ... |
I didn't mean to say that your solution is dirty in any way, quite the contrary actually. It just needs to handle what I pointed above as well, that's all. We are grateful for any help and contribution. |
Sorry, I couldn't squash the commits due to issues with line endings. |
Thanks! The code looks really good. Can you fix the flake8 issues when you get the chance? |
Argh, need to remove the whitespaces from the blank lines, see travis issue. |
Also as an aside, the monkey patching fails for python 3. |
Fixes #3567