Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redundant if/then. #3546

Merged
merged 2 commits into from
Dec 28, 2017
Merged

Removed redundant if/then. #3546

merged 2 commits into from
Dec 28, 2017

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Dec 28, 2017

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@p0psicles
Copy link
Contributor Author

@medariox

@codecov-io
Copy link

codecov-io commented Dec 28, 2017

Codecov Report

Merging #3546 into develop will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3546      +/-   ##
===========================================
+ Coverage    32.97%   32.97%   +<.01%     
===========================================
  Files          275      275              
  Lines        34866    34935      +69     
===========================================
+ Hits         11496    11519      +23     
- Misses       23370    23416      +46
Impacted Files Coverage Δ
medusa/indexers/indexer_base.py 25.67% <0%> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4620266...ea79486. Read the comment docs.

@fernandog fernandog added this to the 0.1.23 milestone Dec 28, 2017
@p0psicles p0psicles merged commit 59bced5 into develop Dec 28, 2017
@medariox medariox deleted the feature/fix-fix-layout branch December 28, 2017 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants