-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all images for a show, using the ImageClass(). #3503
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
5b5add4
Remove all images for a show, using the ImageClass().
p0psicles 26445ea
Clean up remove images
labrys d9182ce
Clean up remove images
labrys d23fde2
Make image cache classless
labrys 16a494a
Make artwork paths more dry, deprecate old methods
labrys c291ddf
Make has_<artwork> methods more dry, deprecate old methods
labrys 5cbc4fd
Remove path dict
labrys fa6715f
Move deprecated paths to bottom of list
labrys 628d676
Refactor TYPE_NAMES -> IMAGE_TYPES
labrys 7ce34cf
Make fill_cache more dry
labrys 9e66861
Make _cache_image_from_indexer more dry
labrys c032a1d
Make _cache_image_from_file more dry
labrys f058764
Make GenericMedia more pythonic and more dry
labrys 57e7178
Use os.path.isfile for get_artwork since it should be a file not a path.
labrys 6cd150b
Update logging and make aspect ratio detection more dry
labrys 9461798
Fix get_media refactor to media
labrys 15d7e2f
Fix logging handler
labrys ec77333
Revert accidental push to wrong branch.
labrys 08ef833
Add button to mass update cached images
fernandog f36c9b9
Fixed bad check if image is exists.
p0psicles File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See one line change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Point is, that this is an object oriented approach. As the logic to delete the files in now in the ImageClass, where it should be. To make it more clean, we could even replace some of logic for cleaning up the images after a show delete, using this method.