Get speed.cd login URL instead of looping a list of URLs #3497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3497 +/- ##
===========================================
- Coverage 32.98% 32.97% -0.02%
===========================================
Files 275 275
Lines 34810 34894 +84
===========================================
+ Hits 11483 11505 +22
- Misses 23327 23389 +62
Continue to review full report at Codecov.
|
p0psicles
reviewed
Dec 19, 2017
| {'url': login_url}) | ||
| continue | ||
| if not (self.urls['login_post'] and self.login_url()): | ||
| log.debug('Unable get login URL') |
p0psicles
reviewed
Dec 19, 2017
| log.debug('Unable to connect to provider using login URL: {url}', | ||
| {'url': self.urls['login_post']}) | ||
| return False | ||
| if re.search('Incorrect username or Password. Please try again.', response.text): |
There was a problem hiding this comment.
You need a regex for this? Can't just do 'sring' in response.text ?
There was a problem hiding this comment.
No ideia. I just removed the for loop. need to check history
p0psicles
approved these changes
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They keep changing login URL (post)
@duramato