Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add network information while adding new show #3430

Merged
merged 2 commits into from
Dec 7, 2017
Merged

Add network information while adding new show #3430

merged 2 commits into from
Dec 7, 2017

Conversation

fernandog
Copy link
Contributor

@fernandog fernandog commented Dec 7, 2017 •
edited
Loading

image

@fernandog fernandog added this to the 0.1.21 milestone Dec 7, 2017
@codecov-io
Copy link

codecov-io commented Dec 7, 2017 •
edited
Loading

Codecov Report

Merging #3430 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3430   +/-   ##
========================================
  Coverage    33.06%   33.06%           
========================================
  Files          275      275           
  Lines        34613    34613           
========================================
  Hits         11446    11446           
  Misses       23167    23167
Impacted Files Coverage Δ
medusa/server/web/home/add_shows.py 11.53% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2d3c32...2563303. Read the comment docs.

@p0psicles
Copy link
Contributor

What does it look like using tmdb or tvmaze?

@fernandog
Copy link
Contributor Author

Doesn't matter which indexer

@fernandog
Copy link
Contributor Author

we use the common field called network

image

@fernandog
Copy link
Contributor Author

btw should we order by date? Seems there is no order in the result list

p0psicles
p0psicles reviewed Dec 7, 2017
View reviewed changes
medusa/server/web/home/add_shows.py Outdated
@@ -100,7 +100,8 @@ def searchIndexersForShowName(search_term, lang=None, indexer=None):

for i, shows in iteritems(results):
final_results.extend({(indexerApi(i).name, i, indexerApi(i).config['show_url'], int(show['id']),
show['seriesname'].encode('utf-8'), show['firstaired']) for show in shows})
show['seriesname'].encode('utf-8'), show['firstaired'] or 'N/A',
show['network'] or 'N/A') for show in shows})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any networks which should be encoded?

@fernandog
Copy link
Contributor Author

@p0psicles anything else?

@p0psicles p0psicles merged commit cb5be6e into develop Dec 7, 2017
@p0psicles p0psicles deleted the feature/new_show_network branch December 7, 2017 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0psicles p0psicles p0psicles approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
0.1.21
Development

Successfully merging this pull request may close these issues.
3 participants
@fernandog @codecov-io @p0psicles