Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NMA: proper handle status code #3418

Merged
merged 4 commits into from
Dec 6, 2017
Merged

NMA: proper handle status code #3418

merged 4 commits into from
Dec 6, 2017

Conversation

fernandog
Copy link
Contributor

@fernandog fernandog commented Dec 6, 2017 •
edited
Loading

@duramato

Seems really inconsistent.
Testing multiple times sometimes it works and sometimes it doesn't

Thread-29 :: [4c2ace8] NMA: Could not send notification to NotifyMyAndroid. Maximum number of API calls per hour exceeded
Thread-28 :: [4c2ace8] NMA: Notification sent to NotifyMyAndroid
Thread-29 :: [4c2ace8] NMA: Could not send notification to NotifyMyAndroid. Maximum number of API calls per hour exceeded
Thread-28 :: [4c2ace8] NMA: Could not send notification to NotifyMyAndroid. Maximum number of API calls per hour exceeded
Thread-29 :: [4c2ace8] NMA: Notification sent to NotifyMyAndroid

@fernandog fernandog added this to the 0.1.20 milestone Dec 6, 2017
p0psicles
p0psicles previously approved these changes Dec 6, 2017
View reviewed changes
@fernandog fernandog force-pushed the feature/nma_402_status_code branch from 5e31001 to bfb0826 Compare December 6, 2017 11:38
@fernandog fernandog changed the title NMA: proper handles status code NMA: proper handle status code Dec 6, 2017
@fernandog
Copy link
Contributor Author

@p0psicles I did two more commits. can you check & approve please?

@fernandog fernandog force-pushed the feature/nma_402_status_code branch from cd790aa to f827af5 Compare December 6, 2017 11:53
p0psicles
p0psicles previously approved these changes Dec 6, 2017
View reviewed changes
@fernandog
Copy link
Contributor Author

@p0psicles need approve again. flake issue

@fernandog fernandog merged commit a0d7d05 into develop Dec 6, 2017
@fernandog fernandog deleted the feature/nma_402_status_code branch December 6, 2017 13:54
@medariox medariox modified the milestone: 0.1.20 Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0psicles p0psicles p0psicles approved these changes

Assignees
No one assigned
Labels
Concluded
Projects
None yet
Milestone
0.1.20
Development

Successfully merging this pull request may close these issues.
3 participants
@fernandog @p0psicles @medariox