Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten the debug output for the torrent client requests. #3406

Merged
merged 4 commits into from
Dec 5, 2017

Conversation

p0psicles
Copy link
Contributor

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@codecov-io
Copy link

codecov-io commented Dec 4, 2017

Codecov Report

Merging #3406 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3406      +/-   ##
===========================================
- Coverage    33.07%   33.07%   -0.01%     
===========================================
  Files          275      275              
  Lines        34582    34583       +1     
===========================================
  Hits         11437    11437              
- Misses       23145    23146       +1
Impacted Files Coverage Δ
medusa/clients/torrent/generic.py 21.19% <0%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8a75d2...99220c4. Read the comment docs.

@fernandog
Copy link
Contributor

Why shorten? Information will be lost

@medariox medariox merged commit e02f924 into develop Dec 5, 2017
@medariox medariox deleted the feature/disable-param-logging-post branch December 5, 2017 18:43
fernandog added a commit to fernandog/Medusa that referenced this pull request Dec 6, 2017
@fernandog
Copy link
Contributor

fernandog commented Dec 6, 2017

@p0psicles this broke transmission too me:

2017-12-05 21:58:55 WARNING  TORRENTCHECKER :: [b175c4b] Transmission: Authentication Failed
2017-12-05 20:58:55 WARNING  TORRENTCHECKER :: [b175c4b] Transmission: Authentication Failed

Reverting this commit works

To confirm run a connection test

@duramato confirm?

@medariox medariox added this to the 0.1.20 milestone Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants