Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error added by qbittorrent 5.0 pymedusa/Medusa#11844 #11857

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

borntohonk
Copy link
Contributor

@borntohonk borntohonk commented Oct 12, 2024

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

Proposed fixes for error(s) from #11844 caused by qbittorrent 5.0 api changes, which for reasons unknown to mortal man is that they changed "pause/paused" to "stop/stopped", and "resume/resumed" to "start".

Things addressed/fixed:

  • Download handler is unable to process completed & "stopped" torrents (completed & uploading/seeding worked fine), which affects people who don't seed or if the download handlers schedule is slower than seeding goal is hit.

  • Log-level error spawned from not being able to parse this new unknown "stopped" state.

Also tested:
qQbittorrent v4.6.7, to ensure new changes to accommodate qQbittorrent v5.0+ does not negatively affect previous version(s)

@XxUnkn0wnxX
Copy link

Is this still being worked on, or is it stuck in limbo?

@borntohonk
Copy link
Contributor Author

Is this still being worked on, or is it stuck in limbo?

I'm not a maintainer so that's not up to me to decide, but I did remove the downloader_handler state per comment, and the "fix" itself does do what it's supposed to do.

@borntohonk
Copy link
Contributor Author

borntohonk commented Nov 22, 2024

(ideally, one would go nag qbittorrent folks to make it backwards compatible instead of this new nonsense https://github.com/qbittorrent/qBittorrent/blob/master/src/webui/www/private/scripts/mocha-init.js#L523-L549 )

(they wont revert or add backwards compatibility see qbittorrent/qBittorrent#20532 as to why 🤡)

medariox
medariox previously approved these changes Dec 10, 2024
@medariox
Copy link
Contributor

LGTM! Thank you 🙏

@medariox medariox merged commit 130bc1a into pymedusa:develop Dec 10, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants