Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Don't wrap status column in larger screens #3592

Closed
h3llrais3r opened this issue Jan 9, 2018 · 2 comments
Closed

[IMPROVEMENT] Don't wrap status column in larger screens #3592

h3llrais3r opened this issue Jan 9, 2018 · 2 comments
Labels

Comments

@h3llrais3r
Copy link
Contributor

h3llrais3r commented Jan 9, 2018

I find it annoying that the status column is wrapped (i.e. when you have episodes with long names).
What do you think of making it 'no-wrap' for larger screens so the layout becomes more clear (i.e. smaller rows).

AS-IS:
image

WITH NO-WRAP:

image

What do you think?
Code:

@media screen and (min-width: 769px) {
    td.col-status {
        white-space: nowrap;
    }
}

Just need your advise on what the min-width should be... if you agree to change it.

@p0psicles
Copy link
Contributor

I think you should test it with more different media queries. If theres really no drawback. Sure let's change it.

@h3llrais3r
Copy link
Contributor Author

h3llrais3r commented Jan 9, 2018

Well I just would leave it wrapped by default, but from a certain width don't wrap it anymore.
These are the boundaries defined in bootstrap:

/* Extra small devices (phones, less than 768px) */
/* No media query since this is the default in Bootstrap */

/* Small devices (tablets, 768px and up) */
@media (min-width: @screen-sm-min) { ... }

/* Medium devices (desktops, 992px and up) */
@media (min-width: @screen-md-min) { ... }

/* Large devices (large desktops, 1200px and up) */
@media (min-width: @screen-lg-min) { ... }

I think we should use one of these?
Perhaps 992 (medium devices and up)?
As you can see it now switches together with full screen width.

I don't think there is any drawback, since the name will still be wrapped if too long.
<992px:
image

>=992px:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants