Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework UUIDv7 generation for conversation_id #75

Merged
merged 4 commits into from
May 6, 2024
Merged

Conversation

BenediktBurger
Copy link
Member

@BenediktBurger BenediktBurger commented Apr 30, 2024

Closes #74

I just added the (failing) test.
Implementation has to be searched for.

@BenediktBurger BenediktBurger marked this pull request as ready for review May 4, 2024 10:23
@BenediktBurger
Copy link
Member Author

Switching to uuid6 package instead of uuid7 package, for more information, see #74

Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.66%. Comparing base (c66873a) to head (b2a3b74).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   87.58%   87.66%   +0.08%     
==========================================
  Files          36       36              
  Lines        2899     2903       +4     
  Branches      355      355              
==========================================
+ Hits         2539     2545       +6     
+ Misses        300      298       -2     
  Partials       60       60              
Flag Coverage Δ
unittests 87.66% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BenediktBurger BenediktBurger merged commit bf70200 into main May 6, 2024
20 checks passed
@BenediktBurger BenediktBurger deleted the fix-uuidv7 branch May 6, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uuid7 package seems to be not up to date with UUIDv7 draft
1 participant