Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coordinator #58

Merged
merged 5 commits into from
Feb 14, 2024
Merged

Fix coordinator #58

merged 5 commits into from
Feb 14, 2024

Conversation

BenediktBurger
Copy link
Member

closes #57 and also closes #56

@BenediktBurger BenediktBurger added the bug Something isn't working label Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cb0328b) 87.02% compared to head (7eb55a5) 87.20%.
Report is 1 commits behind head on main.

Files Patch % Lines
pyleco/coordinators/coordinator.py 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   87.02%   87.20%   +0.18%     
==========================================
  Files          33       33              
  Lines        2589     2626      +37     
  Branches      303      314      +11     
==========================================
+ Hits         2253     2290      +37     
  Misses        282      282              
  Partials       54       54              
Flag Coverage Δ
unittests 87.20% <98.33%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BenediktBurger BenediktBurger merged commit ef56a34 into main Feb 14, 2024
17 checks passed
@BenediktBurger BenediktBurger deleted the fix-coordinator branch February 14, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coordinator regression MessageHandler should allow batch handling
1 participant