Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tanh saturation function #9

Merged
merged 4 commits into from
Mar 14, 2022
Merged

Add tanh saturation function #9

merged 4 commits into from
Mar 14, 2022

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Mar 12, 2022 •
edited
Loading

This PR solves #3

  • Add implementation
  • Write tests

@juanitorduz juanitorduz added the enhancement New feature or request label Mar 12, 2022
@juanitorduz juanitorduz self-assigned this Mar 12, 2022
@juanitorduz juanitorduz requested a review from twiecki March 14, 2022 09:45
twiecki
twiecki reviewed Mar 14, 2022
View reviewed changes
pymmmc/transformers.py Outdated
References
----------
See reducing-customer-acquisition-costs-how-we-helped-optimizing-hellofreshs-marketing-budget
in https://www.pymc-labs.io/blog-posts/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong doc-string, also directly link to https://www.pymc-labs.io/blog-posts/reducing-customer-acquisition-costs-how-we-helped-optimizing-hellofreshs-marketing-budget/

@juanitorduz juanitorduz requested a review from twiecki March 14, 2022 10:09
@twiecki
Copy link
Contributor

twiecki commented Mar 14, 2022 •
edited by juanitorduz
Loading

Looks good so far, you planned to add tests though, right?

@juanitorduz
Copy link
Collaborator Author

Looks good so far, you planned to add tests though, right?

Yes! Is in my TODO list (see first comment in PR) :)

@twiecki
Copy link
Contributor

twiecki commented Mar 14, 2022

OK, best to assign reviews when you consider it's done :).

@juanitorduz
Copy link
Collaborator Author

OK, best to assign reviews when you consider it's done :).

Ups! You are right! Sorry about that 🙈

@juanitorduz
Copy link
Collaborator Author

I have added the corresponding tests so this PR is ready for review. The link errors will be solved if we merge #8 first (which I recommend doing so).

@twiecki twiecki merged commit d1b6016 into main Mar 14, 2022
@twiecki twiecki deleted the feature/saturation_tanh branch March 14, 2022 18:58
@ricardoV94 ricardoV94 added the MMM label Feb 8, 2023
@ricardoV94 ricardoV94 changed the title Add tanh saturation function Add tanh saturation function Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twiecki twiecki twiecki approved these changes

@AlexAndorra AlexAndorra Awaiting requested review from AlexAndorra

@drbenvincent drbenvincent Awaiting requested review from drbenvincent

Assignees

@juanitorduz juanitorduz

Labels
enhancement New feature or request MMM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juanitorduz @twiecki @ricardoV94