Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Visual for hill_saturation function (Issue #851 ) #857

Merged
merged 7 commits into from
Jul 25, 2024
Merged

Fix Visual for hill_saturation function (Issue #851 ) #857

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b8dab0f
Fix plotting by evaluating tensors.
patrick-conundrm Jul 23, 2024
f6b1548
Add space after sphinx directive.
PatrickRobotham Jul 24, 2024
a458613
Remove indentation from blank line.
PatrickRobotham Jul 24, 2024
53576f8
Merge branch 'main' into fix-hill-saturation-docs
wd60622 Jul 24, 2024
f0d7156
Merge branch 'main' into fix-hill-saturation-docs
wd60622 Jul 24, 2024
3e61b4e
Add shared y axis for subplots.
PatrickRobotham Jul 25, 2024
5ae5b5b
Merge branch 'main' into fix-hill-saturation-docs
wd60622 Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions pymc_marketing/mmm/transformers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,47 +924,50 @@ def hill_saturation(

.. plot::
:context: close-figs

import numpy as np
import matplotlib.pyplot as plt
from pymc_marketing.mmm.transformers import hill_saturation
x = np.linspace(0, 10, 100)
# Varying sigma
sigmas = [0.5, 1, 1.5]
plt.figure(figsize=(12, 4))
fig, axes = plt.subplots(1, 3, figsize=(12, 4), sharey=True)
for i, sigma in enumerate(sigmas):
plt.subplot(1, 3, i+1)
y = hill_saturation(x, sigma, 2, 5)
y = hill_saturation(x, sigma, 2, 5).eval()
plt.plot(x, y)
plt.xlabel('x')
plt.ylabel('Hill Saturation')
plt.title(f'Sigma = {sigma}')
plt.subplot(1,3,1)
plt.ylabel('Hill Saturation')
plt.tight_layout()
plt.show()
# Varying beta
betas = [1, 2, 3]
plt.figure(figsize=(12, 4))
fig, axes = plt.subplots(1, 3, figsize=(12, 4), sharey=True)
for i, beta in enumerate(betas):
plt.subplot(1, 3, i+1)
y = hill_saturation(x, 1, beta, 5)
y = hill_saturation(x, 1, beta, 5).eval()
plt.plot(x, y)
plt.xlabel('x')
plt.ylabel('Hill Saturation')
plt.title(f'Beta = {beta}')
plt.subplot(1,3,1)
plt.ylabel('Hill Saturation')
plt.tight_layout()
plt.show()
# Varying lam
lams = [3, 5, 7]
plt.figure(figsize=(12, 4))
fig, axes = plt.subplots(1, 3, figsize=(12, 4), sharey=True)
for i, lam in enumerate(lams):
plt.subplot(1, 3, i+1)
y = hill_saturation(x, 1, 2, lam)
y = hill_saturation(x, 1, 2, lam).eval()
plt.plot(x, y)
plt.xlabel('x')
plt.ylabel('Hill Saturation')
plt.title(f'Lambda = {lam}')
plt.subplot(1,3,1)
plt.ylabel('Hill Saturation')
plt.tight_layout()
plt.show()

Parameters
----------
x : float or array-like
Expand Down
Loading