Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMM notebook small fixes #626

Merged
merged 1 commit into from
Apr 12, 2024
Merged

MMM notebook small fixes #626

merged 1 commit into from
Apr 12, 2024

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Apr 11, 2024

Small Fixes: formatting and a small typo in a plot, which was breaking a plot because of LaTeX.

I catch this one because of #624


📚 Documentation preview 📚: https://pymc-marketing--626.org.readthedocs.build/en/626/

@juanitorduz juanitorduz self-assigned this Apr 11, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@juanitorduz juanitorduz added docs Improvements or additions to documentation MMM labels Apr 11, 2024
@juanitorduz juanitorduz requested a review from wd60622 April 11, 2024 22:11
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.64%. Comparing base (c40c8b8) to head (8908727).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #626   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files          22       22           
  Lines        2273     2273           
=======================================
  Hits         2083     2083           
  Misses        190      190           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
The formatted docs are much easier on the eyes 😄

@juanitorduz juanitorduz merged commit ff937f4 into main Apr 12, 2024
11 checks passed
@juanitorduz juanitorduz deleted the fix_mmm-nb2 branch April 12, 2024 05:39
twiecki pushed a commit that referenced this pull request Sep 10, 2024
twiecki pushed a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation MMM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants