Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more unused config options #948

Merged
merged 8 commits into from
Jul 23, 2024
Merged

Remove more unused config options #948

merged 8 commits into from
Jul 23, 2024

Conversation

Armavica
Copy link
Member

@Armavica Armavica commented Jul 19, 2024

Description

Note that I changed the value of in_c_key for cast_policy because I assumed that it was meant to be False, but I could be wrong.

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@Armavica Armavica marked this pull request as ready for review July 19, 2024 22:30
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.

Project coverage is 81.60%. Comparing base (981688c) to head (1ba828e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #948      +/-   ##
==========================================
+ Coverage   81.59%   81.60%   +0.01%     
==========================================
  Files         178      178              
  Lines       47236    47209      -27     
  Branches    11483    11478       -5     
==========================================
- Hits        38544    38527      -17     
+ Misses       6504     6496       -8     
+ Partials     2188     2186       -2     
Files Coverage Δ
pytensor/configparser.py 92.58% <100.00%> (+2.73%) ⬆️
pytensor/configdefaults.py 71.61% <66.66%> (-1.06%) ⬇️
pytensor/compile/profiling.py 76.15% <0.00%> (ø)
pytensor/scalar/basic.py 80.38% <0.00%> (ø)

... and 2 files with indirect coverage changes

@Armavica Armavica requested a review from ricardoV94 July 20, 2024 16:49
@ricardoV94
Copy link
Member

Why didn't tests run?

@maresb
Copy link
Contributor

maresb commented Jul 21, 2024

Why didn't tests run?

What do you mean?

image

@ricardoV94
Copy link
Member

Ugh, in the android app I see this: Screenshot_20240721-114454.png

@maresb
Copy link
Contributor

maresb commented Jul 21, 2024

Ok, so it was just a glitch? (GitHub seems really flaky about this stuff in general.)

@Armavica
Copy link
Member Author

You might be seeing an earlier workflow, not the final one

@Armavica Armavica merged commit d455460 into pymc-devs:main Jul 23, 2024
63 of 114 checks passed
@Armavica Armavica deleted the config branch July 23, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants