Implement indexing operations in PyTorch

[HarshvirSandhu]

Implement indexing ops in pytorch

• Subtensor
• IncSubtensor
• AdvancedSubtensor[1]
• AdvancedIncSubtensor[1]

Description

Related Issue

• Related to Implement all Ops in PyTorch (help welcome!) #821

Checklist

• Checked that the pre-commit linting/style checks pass
• Included tests that prove the fix is effective or that the new feature works

Type of change

• New feature / enhancement

[codecov]

Codecov Report

Attention: Patch coverage is 85.41667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 81.74%. Comparing base (1a1c62b) to head (b38a01c).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pytensor/link/pytorch/dispatch/subtensor.py	84.61%	9 Missing and 3 partials ⚠️
pytensor/link/pytorch/dispatch/basic.py	87.50%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #910   +/-   ##
=======================================
  Coverage   81.73%   81.74%           
=======================================
  Files         182      183    +1     
  Lines       47633    47724   +91     
  Branches    11604    11616   +12     
=======================================
+ Hits        38934    39011   +77     
- Misses       6509     6520   +11     
- Partials     2190     2193    +3     

Files with missing lines	Coverage Δ
pytensor/compile/mode.py	84.54% <ø> (ø)
pytensor/link/pytorch/dispatch/__init__.py	100.00% <100.00%> (ø)
pytensor/link/pytorch/dispatch/basic.py	93.33% <87.50%> (-1.54%)	⬇️
pytensor/link/pytorch/dispatch/subtensor.py	84.61% <84.61%> (ø)

[ricardoV94]

This is looking pretty good! Some change requests and suggestions to make the tests more robust.

[ricardoV94]

Getting there, some smaller feedback this time

[ricardoV94]

@HarshvirSandhu I pushed some simplification and also needed special logic for repeated indices in IncSubtensor. Feel free to review and see if you spot any issues. Note that I squashed the commits and force-pushed, so you'll have to retrieve the remote branch before you can do any changes

[ricardoV94]

This works for me locally, are you sure it wasn't working on your end?