Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows build #909

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix Windows build #909

merged 1 commit into from
Jul 10, 2024

Conversation

Armavica
Copy link
Member

@Armavica Armavica commented Jul 9, 2024

Description

Fixes #806 (comment)

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.34%. Comparing base (2effaf1) to head (4dcbb75).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #909   +/-   ##
=======================================
  Coverage   81.34%   81.34%           
=======================================
  Files         170      170           
  Lines       46833    46833           
  Branches    11432    11432           
=======================================
  Hits        38097    38097           
  Misses       6549     6549           
  Partials     2187     2187           
Files Coverage Δ
pytensor/configdefaults.py 71.42% <0.00%> (ø)

@ricardoV94 ricardoV94 added the bug Something isn't working label Jul 9, 2024
@Armavica
Copy link
Member Author

Armavica commented Jul 9, 2024

@maresb Do you think there would be a way to add this test to the test suite? I am not sure how the conda build works

Copy link
Contributor

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well we're currently only testing under Ubuntu, so we'd just need to add Windows and see if PyTensor imports without warnings.

I'm not sure if you've verified this, but I'm personally fine with taking an experimental approach here, just cutting a release and seeing if it works.

@ricardoV94 ricardoV94 merged commit 223b739 into pymc-devs:main Jul 10, 2024
58 of 59 checks passed
@Armavica Armavica deleted the fix-windows-build branch July 11, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants