Implemented Sort/Argsort Ops in PyTorch #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #897 +/- ##
=======================================
Coverage 81.24% 81.25%
=======================================
Files 170 171 +1
Lines 46920 46945 +25
Branches 11482 11484 +2
=======================================
+ Hits 38120 38144 +24
Misses 6600 6600
- Partials 2200 2201 +1
|
|
What happens with axis=None that introduces a reshape? |
I think it is this line. But I should rather remove that test and don't test for |
|
I see, you can test and mark it as xfail with pytest.mark.xfail |
ricardoV94
requested changes
Jul 8, 2024
tests/link/pytorch/test_sort.py
Outdated
| @@ -7,17 +7,12 @@ | |||
| from tests.link.pytorch.test_basic import compare_pytorch_and_py | |||
|
|
|||
|
|
|||
| @pytest.mark.xfail(reason="Reshape not implemented") | |||
| @pytest.mark.parametrize("axis", [0, 1, None]) | |||
There was a problem hiding this comment.
When only some of the parametrized conditions fail, you should use pytest.param to mark that specifically as xfailing. The others are working and shouldn't be marked. There are some examples in the tests somewhere
48 tasks
twaclaw
force-pushed
the
implement_sort_argsort_ops_torch
branch
from
a9e2343
to
cff4cf4
Compare
ricardoV94
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SortOpinPyTorchArgSortOpinPyTorchaxis=Nonethrows an exception becauseReshapeis not yet implementedRelated Issue
Checklist
Type of change