Vectorize make_vector
#889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
vectorize_make_vector
branch
from
ea5fe1c
to
4a9077b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #889 +/- ##
=======================================
Coverage 81.21% 81.21%
=======================================
Files 170 170
Lines 47020 47028 +8
Branches 11523 11525 +2
=======================================
+ Hits 38188 38196 +8
Misses 6621 6621
Partials 2211 2211
|
|
I should test it doesn't fail when all inputs are still scalars |
jessegrabowski
approved these changes
Jul 7, 2024
| new_out = join( | ||
| -1, *[expand_dims(batch_inputs, axis=-1) for batch_inputs in batch_inputs] | ||
| ) | ||
| return new_out.owner |
There was a problem hiding this comment.
vectorize_node returns a node. No idea why, could probably have made it like rewrites and return the output variables
There was a problem hiding this comment.
I guess it's right there in the name eh?
There was a problem hiding this comment.
It's silly and potentially too restrictive, opened an issue: #902
ricardoV94
force-pushed
the
vectorize_make_vector
branch
from
4a9077b
to
7f19764
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Showed up in some vectorized logps in pymc-devs/pymc-experimental#353
We can always convert a vectorized MakeVector (stack of scalars) into a join (concatenate) of tensors. May just need to explicitly broadcast them first. No good reason not to do it eagerly
Related Issue
Checklist
Type of change