Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix too restrictive type assert #880

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Fix too restrictive type assert #880

merged 1 commit into from
Jul 4, 2024

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Jul 4, 2024 •
edited
Loading

Introduced in f9dfe70

Causing PyMC CI to fail in pymc-devs/pymc#7400

https://github.com/pymc-devs/pymc/actions/runs/9790920723/job/27033597109?pr=7400#step:7:3094

Description

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@ricardoV94 ricardoV94 added the bug Something isn't working label Jul 4, 2024
@ricardoV94 ricardoV94 changed the title Fix wrong type assert Fix too restrictive type assert Jul 4, 2024
@ricardoV94 ricardoV94 requested a review from twiecki July 4, 2024 09:22
@ricardoV94 ricardoV94 merged commit afc1a6c into pymc-devs:main Jul 4, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelosthege michaelosthege michaelosthege approved these changes

@twiecki twiecki Awaiting requested review from twiecki

Assignees
No one assigned
Labels
bug Something isn't working typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardoV94 @michaelosthege