Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented JAX backend for Eigvalsh #867

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

HangenYuu
Copy link
Contributor

Description

Added JAX backend for Eigvalsh Op.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.99%. Comparing base (7a00b88) to head (ba2d558).
Report is 152 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
- Coverage   80.99%   80.99%   -0.01%     
==========================================
  Files         169      169              
  Lines       46939    46971      +32     
  Branches    11467    11481      +14     
==========================================
+ Hits        38019    38042      +23     
- Misses       6713     6717       +4     
- Partials     2207     2212       +5     
Files with missing lines Coverage Δ
pytensor/link/jax/dispatch/slinalg.py 95.12% <100.00%> (+1.57%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Member

@jessegrabowski jessegrabowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- quite straightforward. Just a small suggestion to make the error message a bit more clear.

pytensor/link/jax/dispatch/slinalg.py Outdated Show resolved Hide resolved
Co-authored-by: Jesse Grabowski <48652735+jessegrabowski@users.noreply.github.com>
@ricardoV94 ricardoV94 merged commit f3d2ede into pymc-devs:main Jun 28, 2024
57 checks passed
@ricardoV94
Copy link
Member

Awesome @HangenYuu !

@HangenYuu HangenYuu deleted the jax_eigvalsh_implement branch July 3, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing JAX implementation of Eigvalsh
3 participants