Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more cases of advanced indexing in Numba #818

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

ricardoV94
Copy link
Member

Description

Follow up to #805

Support more multidimensional advanced indexing cases by converting them to vector advanced indexing via rewrites.

We could do similar stuff to support multi-dimensional Set/IncSubtensor

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@ricardoV94 ricardoV94 changed the title Support more cases of advancde index in Numba Support more cases of advanced index in Numba Jun 13, 2024
@ricardoV94 ricardoV94 changed the title Support more cases of advanced index in Numba Support more cases of advanced indexing in Numba Jun 13, 2024
@ricardoV94
Copy link
Member Author

Marked as a draft because it includes commits from #805

@ricardoV94 ricardoV94 force-pushed the numba_adv_idx_enh branch 3 times, most recently from b269182 to 913f1e4 Compare June 21, 2024 11:09
@ricardoV94 ricardoV94 marked this pull request as ready for review July 3, 2024 12:51
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.05%. Comparing base (df769f6) to head (e2e1144).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #818      +/-   ##
==========================================
+ Coverage   81.03%   81.05%   +0.02%     
==========================================
  Files         169      169              
  Lines       46845    46884      +39     
  Branches    11485    11495      +10     
==========================================
+ Hits        37959    38003      +44     
+ Misses       6679     6675       -4     
+ Partials     2207     2206       -1     
Files Coverage Δ
pytensor/tensor/rewriting/subtensor.py 90.05% <100.00%> (+1.04%) ⬆️

@ricardoV94 ricardoV94 merged commit 8550622 into pymc-devs:main Jul 6, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants