Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types to functions in printing.py #804

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Add types to functions in printing.py #804

merged 3 commits into from
Jun 6, 2024

Conversation

Armavica
Copy link
Member

@Armavica Armavica commented Jun 5, 2024

Description

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.76%. Comparing base (b7b309d) to head (b1cd232).
Report is 182 commits behind head on main.

Files with missing lines Patch % Lines
pytensor/printing.py 80.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #804      +/-   ##
==========================================
- Coverage   80.76%   80.76%   -0.01%     
==========================================
  Files         163      163              
  Lines       46941    46939       -2     
  Branches    11499    11500       +1     
==========================================
- Hits        37912    37910       -2     
  Misses       6786     6786              
  Partials     2243     2243              
Files with missing lines Coverage Δ
pytensor/printing.py 51.33% <80.00%> (-0.12%) ⬇️

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 😃

@ricardoV94 ricardoV94 merged commit 086323f into main Jun 6, 2024
55 of 56 checks passed
@Armavica Armavica deleted the printing-types branch June 6, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants