-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved mypy from pre-commit to GitHub Action #775
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #775 +/- ##
=======================================
Coverage 80.85% 80.85%
=======================================
Files 162 162
Lines 47016 47016
Branches 11501 11501
=======================================
Hits 38014 38014
Misses 6751 6751
Partials 2251 2251 |
The workflow is up and running. What I have done:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @HangenYuu! I think we can squash-merge this as-is.
Would you be willing to do a followup PR on this to get rid of the old and unstable setup-miniconda
action in favor of the newer and much simpler setup-micromamba
action?
I did this in pymc-devs/pymc#7213, but it didn't get merged and became stale due to some issues with the tests. You should be able to use that as a template. Basically what you need to do is:
- Add the shell initialization so that the Conda environment is properly activated:
defaults:
run:
shell: bash -leo pipefail {0}
- Delete the cache actions
- Replace
setup-miniconda
with the much simplersetup-micromamba
and adapt the settings, which I think you could basically copy from Switch to setup-micromamba action pymc#7213 with minor adaptations.
Does this make sense, and is it something you'd be able to help with? Thanks a lot!
Hi @maresb, yes I would like to help! |
Thanks a ton @HangenYuu |
Thanks again @HangenYuu! Feel free to tackle the task I described above, and let me know if you have any questions. |
Description
Move mypy action out of .pre-commit to run on GitHub Action only due to slowness.
Related Issue
Checklist
Type of change