Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pad #748

Merged
merged 38 commits into from
Jul 19, 2024
Merged

Implement pad #748

merged 38 commits into from
Jul 19, 2024

Commits on Jul 7, 2024

  1. Refactor linspace, logspace, and geomspace to match numpy implementation

    @jessegrabowski
    jessegrabowski committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    91311d5 View commit details
    Browse the repository at this point in the history

  2. Add pt.pad

    @jessegrabowski
    jessegrabowski committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    a98b8ae View commit details
    Browse the repository at this point in the history

  3. Use subclassed OpFromGraph to represent pad Op

    @jessegrabowski
    jessegrabowski committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    02566b6 View commit details
    Browse the repository at this point in the history

  4. Add test for flip

    @jessegrabowski
    jessegrabowski committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    32b14d2 View commit details
    Browse the repository at this point in the history

  5. Address reviewer feedback

    @jessegrabowski
    jessegrabowski committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    3e65827 View commit details
    Browse the repository at this point in the history

  6. Remove inplace argument to set_subtensor

    @jessegrabowski
    jessegrabowski committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    c2b8465 View commit details
    Browse the repository at this point in the history

  7. Delay setting dtype of xspace Ops until after all computation to ma… 

    …tch numpy outputs
    @jessegrabowski
    jessegrabowski committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    8f213a3 View commit details
    Browse the repository at this point in the history

  8. Use shape_padright instead of .reshape tricks

    @jessegrabowski
    jessegrabowski committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    be6ed82 View commit details
    Browse the repository at this point in the history

  9. Add test for dtype kwarg on xspace Ops

    @jessegrabowski
    jessegrabowski committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    9c76a8f View commit details
    Browse the repository at this point in the history

  10. Save keyword arguments in Pad OpFromGraph

    @jessegrabowski
    jessegrabowski committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    eeb9fa3 View commit details
    Browse the repository at this point in the history

  11. Add test for arbitrary padding at higher dimensions

    @jessegrabowski
    jessegrabowski committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    c28faaa View commit details
    Browse the repository at this point in the history

  12. First draft JAX overload

    @jessegrabowski
    jessegrabowski committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    ab99a1e View commit details
    Browse the repository at this point in the history

  13. Expect symbolic num argument 

    Fill out `_broadcast_inputs` docstring
    @jessegrabowski
    jessegrabowski committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    e93fa56 View commit details
    Browse the repository at this point in the history

  14. Split wrap_pad into separate function; eliminate use of scan

    @jessegrabowski
    jessegrabowski committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    2d55a06 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. <<DO NOT MERGE>> testing notebook

    @jessegrabowski
    jessegrabowski committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    48037c6 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Add reflect and symmetric padding

    @jessegrabowski
    jessegrabowski committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    b4ffdc5 View commit details
    Browse the repository at this point in the history

  2. Remove test notebook

    @jessegrabowski
    jessegrabowski committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    6808648 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. Correct reflect and symmetric implementations

    @jessegrabowski
    jessegrabowski committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    0f9ca38 View commit details
    Browse the repository at this point in the history

  2. Fix docs, JAX test

    @jessegrabowski
    jessegrabowski committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    c1dd0bc View commit details
    Browse the repository at this point in the history

  3. Remove _broadcast_inputs helper, update docstrings

    @jessegrabowski
    jessegrabowski committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    3b34779 View commit details
    Browse the repository at this point in the history

  4. Remove OpFromGraph and associated JAX dispatch

    @jessegrabowski
    jessegrabowski committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    4cd9702 View commit details
    Browse the repository at this point in the history

  5. Revert "Remove OpFromGraph and associated JAX dispatch" 

    This reverts commit 4cd9702.
    @jessegrabowski
    jessegrabowski committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    dbda326 View commit details
    Browse the repository at this point in the history

  6. Add issue link to reflect_type error message

    @jessegrabowski
    jessegrabowski committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    32ae3eb View commit details
    Browse the repository at this point in the history

  7. Move flip to tensor/subtensor.py, add docstring

    @jessegrabowski
    jessegrabowski committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    d543ed6 View commit details
    Browse the repository at this point in the history

  8. Move slice_at_axis to tensor/subtensor and expose it in `pytensor… 

    ….tensor`
    @jessegrabowski
    jessegrabowski committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    ba6c613 View commit details
    Browse the repository at this point in the history

  9. Appease mypy

    @jessegrabowski
    jessegrabowski committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    aa95403 View commit details
    Browse the repository at this point in the history

  10. Appease mypy, add docstring to pad

    @jessegrabowski
    jessegrabowski committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    2a11ffa View commit details
    Browse the repository at this point in the history

  11. Appease mypy, add docstring to pad

    @jessegrabowski
    jessegrabowski committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    89f8cdf View commit details
    Browse the repository at this point in the history

  12. Fix doctests

    @jessegrabowski
    jessegrabowski committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    0f5e2ba View commit details
    Browse the repository at this point in the history

  13. Fix doctests

    @jessegrabowski
    jessegrabowski committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    74e39b2 View commit details
    Browse the repository at this point in the history

  14. Fix doctests

    @jessegrabowski
    jessegrabowski committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    d169928 View commit details
    Browse the repository at this point in the history

  15. Propagate all optional arguments to JAX

    @jessegrabowski
    jessegrabowski committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    e429bab View commit details
    Browse the repository at this point in the history

  16. Propagate all optional arguments to JAX

    @jessegrabowski
    jessegrabowski committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    8722bfe View commit details
    Browse the repository at this point in the history

  17. Appease mypy

    @jessegrabowski
    jessegrabowski committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    3f8a377 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2024

  1. Test NUMBA backend

    @jessegrabowski
    jessegrabowski committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    163b441 View commit details
    Browse the repository at this point in the history

  2. I love mypy

    @jessegrabowski
    jessegrabowski committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    2c9f727 View commit details
    Browse the repository at this point in the history

  3. Skip failing numba test

    @jessegrabowski
    jessegrabowski committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    19ed2c0 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Merge branch 'main' into pad

    @jessegrabowski
    jessegrabowski authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    bbeb300 View commit details
    Browse the repository at this point in the history