Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test time action #1219

Merged
merged 8 commits into from
Feb 24, 2025
Merged

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Feb 19, 2025

Description

Changes:

  • fail if no tests are found
  • filter down to actions from main branch and more than 10 minutes (those not skipped)
  • link the github action logs used
  • Use REST endpoint for logs as the other wasn't returning for some reason
  • Update the prefix based on recent matrix changes

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pytensor--1219.org.readthedocs.build/en/1219/

@wd60622 wd60622 marked this pull request as ready for review February 20, 2025 07:09
@wd60622
Copy link
Contributor Author

wd60622 commented Feb 20, 2025

I made some adjustment which hopefully let us know if the action is working as expected. I just ran the action (logs here #1124). Are the correct test jobs being logged now? Should we skip or not skip some still?

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ricardoV94
Copy link
Member

What are we skipping right now?

@wd60622
Copy link
Contributor Author

wd60622 commented Feb 20, 2025

What are we skipping right now?

Py3.10 or float32 1 or Benchmark

@ricardoV94
Copy link
Member

Perfect then!

@ricardoV94
Copy link
Member

ricardoV94 commented Feb 20, 2025

What about the numpy 2 distinction. Should be enough to include >2.0 and exclude the others.

but the linked issue looked good...

@wd60622
Copy link
Contributor Author

wd60622 commented Feb 20, 2025

What about the numpy 2 distinction. Should be enough to include >2.0 and exclude the others.

but the linked issue looked good...

All of the py3.12 are using numpy>=2 to my knowledge. Should it be explicit filter?

@ricardoV94
Copy link
Member

What about the numpy 2 distinction. Should be enough to include >2.0 and exclude the others.
but the linked issue looked good...

All of the py3.12 are using numpy>=2 to my knowledge. Should it be explicit filter?

No, I just wanted to double check

@ricardoV94
Copy link
Member

This will be outdated again by #1199 so we may want to wait?

@ricardoV94
Copy link
Member

@wd60622 #1199 is merged

@wd60622
Copy link
Contributor Author

wd60622 commented Feb 21, 2025

@wd60622 #1199 is merged

Should be good to go. I just ran and it edited issue correctly

@wd60622
Copy link
Contributor Author

wd60622 commented Feb 24, 2025

Anything to do on this?

@ricardoV94 ricardoV94 merged commit 4c27eb9 into pymc-devs:main Feb 24, 2025
19 checks passed
@ricardoV94
Copy link
Member

Thanks @wd60622

Aarsh-Wankar pushed a commit to Aarsh-Wankar/pytensor that referenced this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants