-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate batched blas stuff #1215
base: main
Are you sure you want to change the base?
Deprecate batched blas stuff #1215
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1215 +/- ##
==========================================
+ Coverage 81.99% 82.00% +0.01%
==========================================
Files 188 188
Lines 48566 48514 -52
Branches 8677 8657 -20
==========================================
- Hits 39823 39786 -37
+ Misses 6580 6573 -7
+ Partials 2163 2155 -8
|
c58f0be
to
7a47d53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm except for the test cases that you removed. Why did you have to do that? Maybe it was because there were some redundant tests. If it was because some test stopped working with the changes, then I don’t think that’s right
No everything works, but those wouldn't be testing |
This should be merged after #1194 to avoid conflicts.
Closes #608
📚 Documentation preview 📚: https://pytensor--1215.org.readthedocs.build/en/1215/