-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove accidental print statements #1193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:D
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (7.22%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1193 +/- ##
=======================================
Coverage 82.29% 82.29%
=======================================
Files 186 186
Lines 48034 48029 -5
Branches 8629 8629
=======================================
- Hits 39528 39524 -4
+ Misses 6348 6347 -1
Partials 2158 2158
|
I think proper logging would be more appropriate for some of these prints? |
Yes, let's open an issue for that, don't want to do it myself |
Opened #1195 |
Also include ruff rule to avoid it in the future :)
Closes #709
📚 Documentation preview 📚: https://pytensor--1193.org.readthedocs.build/en/1193/