Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove accidental print statements #1193

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Feb 5, 2025

Also include ruff rule to avoid it in the future :)

Closes #709


📚 Documentation preview 📚: https://pytensor--1193.org.readthedocs.build/en/1193/

Copy link
Contributor

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 7.22892% with 77 lines in your changes missing coverage. Please review.

Project coverage is 82.29%. Comparing base (4ac1e63) to head (8b6201d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pytensor/compile/compiledir.py 0.00% 23 Missing ⚠️
pytensor/graph/features.py 18.18% 9 Missing ⚠️
pytensor/graph/rewriting/basic.py 10.00% 9 Missing ⚠️
pytensor/breakpoint.py 0.00% 8 Missing ⚠️
pytensor/link/c/basic.py 0.00% 6 Missing ⚠️
pytensor/compile/debugmode.py 0.00% 4 Missing ⚠️
pytensor/tensor/nlinalg.py 0.00% 4 Missing ⚠️
pytensor/tensor/rewriting/elemwise.py 0.00% 4 Missing ⚠️
pytensor/compile/monitormode.py 0.00% 3 Missing ⚠️
pytensor/compile/profiling.py 0.00% 2 Missing ⚠️
... and 4 more

❌ Your patch status has failed because the patch coverage (7.22%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1193   +/-   ##
=======================================
  Coverage   82.29%   82.29%           
=======================================
  Files         186      186           
  Lines       48034    48029    -5     
  Branches     8629     8629           
=======================================
- Hits        39528    39524    -4     
+ Misses       6348     6347    -1     
  Partials     2158     2158           
Files with missing lines Coverage Δ
pytensor/graph/fg.py 90.69% <100.00%> (ø)
pytensor/link/c/op.py 61.87% <100.00%> (ø)
pytensor/tensor/basic.py 91.37% <ø> (-0.01%) ⬇️
pytensor/tensor/rewriting/math.py 88.80% <ø> (-0.01%) ⬇️
pytensor/compile/mode.py 84.72% <0.00%> (ø)
pytensor/compile/nanguardmode.py 62.37% <0.00%> (ø)
pytensor/tensor/rewriting/blas.py 89.64% <0.00%> (ø)
pytensor/compile/profiling.py 76.15% <0.00%> (ø)
pytensor/printing.py 51.67% <33.33%> (+0.05%) ⬆️
pytensor/compile/monitormode.py 63.04% <0.00%> (ø)
... and 8 more

... and 1 file with indirect coverage changes

@Armavica
Copy link
Member

Armavica commented Feb 5, 2025

I think proper logging would be more appropriate for some of these prints?

@ricardoV94
Copy link
Member Author

I think proper logging would be more appropriate for some of these prints?

Yes, let's open an issue for that, don't want to do it myself

@ricardoV94 ricardoV94 merged commit 17748b7 into pymc-devs:main Feb 5, 2025
64 of 65 checks passed
@ricardoV94 ricardoV94 deleted the remove_print_statements branch February 5, 2025 16:30
@ricardoV94
Copy link
Member Author

Opened #1195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pre-commit hook to avoid print statements.
3 participants